Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sleek-sql 0.3.0 (new formula) #194786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nemith
Copy link
Contributor

@nemith nemith commented Oct 17, 2024

This adds the sleek command line utility for formatting SQL code.

On the naming: There is already a cask with the name of sleek. I am not 100% sure if that conflicts with formulae but just in case this formula was named sleek-sql instead.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Oct 17, 2024
Formula/s/sleek-sql.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. automerge-skip `brew pr-automerge` will skip this pull request labels Oct 17, 2024
@daeho-ro
Copy link
Contributor

daeho-ro commented Oct 20, 2024

73c66c0 has 2 parents. Please rebase against origin/master.

@github-actions github-actions bot removed automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. labels Oct 21, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 21, 2024
@@ -0,0 +1,20 @@
class SleekSql < Formula
Copy link
Member

@chenrui333 chenrui333 Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a second thought, why dont we just name the formula as sleek?

Copy link
Contributor Author

@nemith nemith Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with that. There is a cask with the same name that is completely different. I don't know what the policy is between casks and formulas.

$ brew info sleek
==> sleek: 2.0.14
https://github.com/ransome1/sleek
Not installed
From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/s/sleek.rb
==> Name
sleek
==> Description
Todo manager based on the todo.txt syntax
==> Artifacts
sleek.app (App)
==> Analytics
install: 25 (30 days), 90 (90 days), 375 (365 days)

@chenrui333 chenrui333 removed the ready to merge PR can be merged once CI is green label Oct 21, 2024
This adds the sleek command line utility for formatting SQL code.

On the naming:  There is already a cask with the name of sleek.  I am not 100%
sure if that conflicts with formulae but just in case this formula was named
`sleek-sql` instead.

Update Formula/s/sleek-sql.rb

Co-authored-by: Rui Chen <rui@chenrui.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants