-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libunistring 1.3 #194691
base: master
Are you sure you want to change the base?
libunistring 1.3 #194691
Conversation
4a0d5f5
to
5eabf8b
Compare
5eabf8b
to
8d960cf
Compare
After downloading the built bottles here, running @Bo98 any ideas? |
Hmm, I see. The Sequoia builds are missing |
Can have a look further at some point in the weekend but we should probably have a test for iconv support in libunistring directly. |
07a4923
to
b6273d1
Compare
Probably at least in part covered by |
b6273d1
to
76ad1a2
Compare
Ahh this explains why it only happens on macOS 15: https://github.com/Homebrew/brew/blob/6f17b0644771e0a1d7c15ac72471dae2ef87314a/Library/Homebrew/extend/os/mac/extend/ENV/super.rb#L137. Upstream have decided to no longer allow macOS iconv: coreutils/gnulib@bab1308 & https://savannah.gnu.org/bugs/?65686 |
76ad1a2
to
ba456c6
Compare
Seems very messy if it bleeds into gettext. It has to be said, the situation has been like this for an entire year and precisely zero people appear to have noticed or complained. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
Bleeding into |
970b04b
to
79cad0b
Compare
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: Rui Chen <rui@chenrui.dev>
79cad0b
to
c03be61
Compare
Note: it is not quite the case that precisely zero people have noticed or complained: #142490 (comment) |
Created by
brew bump
Created with
brew bump-formula-pr
.