Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 23.0.0 #194645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

node 23.0.0 #194645

wants to merge 1 commit into from
+4 −5

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Oct 16, 2024 •
edited by chenrui333
Loading

Created by brew bump

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Oct 16, 2024
@BrewTestBot @chenrui333
node 23.0.0
7e0d321 
node: npm 10.9.0

Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 16, 2024
@branchvincent
Copy link
Member

From #193982, I think we also want to ship this with corepack enabled

@bcomnes
Copy link
Contributor

bcomnes commented Oct 18, 2024

Anything I can do to help get this landed?

@Bo98
Copy link
Member

Bo98 commented Oct 19, 2024 •
edited
Loading

Anything I can do to help get this landed?

There's a significant regression in path handling that's getting fixed in nodejs/node#55414. We can probably cherry-pick that once its merged.

@bcomnes
Copy link
Contributor

bcomnes commented Oct 19, 2024

Ouch sounds bad. Thanks for the context.

@AnthonyPoschen
Copy link

any chance to get a bump to 22.10.0 in the meantime?
came across an issue that was patched with the latest patch fix.
nodejs/node#54573 (comment)

@SMillerDev
Copy link
Member

any chance to get a bump to 22.10.0 in the meantime? came across an issue that was patched with the latest patch fix. nodejs/node#54573 (comment)

Go ahead: https://docs.brew.sh/Updating-Software-in-Homebrew

@harpchad
Copy link
Contributor

any chance to get a bump to 22.10.0 in the meantime? came across an issue that was patched with the latest patch fix. nodejs/node#54573 (comment)

Go ahead: https://docs.brew.sh/Updating-Software-in-Homebrew

#195089

@ovflowd
Copy link

ovflowd commented Oct 21, 2024

Anything I can do to help get this landed?

There's a significant regression in path handling that's getting fixed in nodejs/node#55414. We can probably cherry-pick that once its merged.

We got this merged, but it is pending release. Thanks for keeping an eye on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@BrewTestBot @branchvincent @bcomnes @Bo98 @AnthonyPoschen @SMillerDev @harpchad @ovflowd