Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/Installation: fix Apple Developer account link #15667

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

gerlero
Copy link
Contributor

@gerlero gerlero commented Jul 11, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes the link to the Apple Developer account page in the footnote, which is now giving a 404.

Not sure if the "Mac OS X" mention on the same line shouldn't also be changed to "macOS"...

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Not sure if the "Mac OS X" mention on the same line shouldn't also be changed to "macOS"...

If they refer to versions that are called macOS1, it should be changed to "macOS".

Footnotes

  1. I think this is Sierra and newer?

@gerlero
Copy link
Contributor Author

gerlero commented Jul 12, 2023

Well, the section that has that footnote also says macOS Big Sur or higher is required, so "macOS" it is. I'll add that change here too.

  1. I think this is Sierra and newer?

That's right!

@carlocab carlocab merged commit 9e8a777 into Homebrew:master Jul 12, 2023
24 checks passed
@@ -90,6 +90,6 @@ Uninstallation is documented in the [FAQ](FAQ.md).

<a name="2"><sup>2</sup></a> macOS 11 (Big Sur) or higher is best and supported, 10.11 (El Capitan) – 10.15 (Catalina) are unsupported but may work and 10.10 (Yosemite) and older will not run Homebrew at all. For 10.4 (Tiger) – 10.6 (Snow Leopard) see [Tigerbrew](https://github.com/mistydemeo/tigerbrew).

<a name="3"><sup>3</sup></a> You may need to install Xcode, the CLT, or both depending on the formula, to install a bottle (binary package) which is the only supported configuration. Downloading Xcode may require an Apple Developer account on older versions of Mac OS X. Sign up for free at [Apple's website](https://developer.apple.com/register/index.action).
<a name="3"><sup>3</sup></a> You may need to install Xcode, the CLT, or both depending on the formula, to install a bottle (binary package) which is the only supported configuration. Downloading Xcode may require an Apple Developer account on older versions of macOS. Sign up for free at [Apple's website](https://developer.apple.com/account/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerlero @carlocab sorry, this is wrong: it should be Mac OS X because it only applies there!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I got it wrong then (honestly, I'm not really sure how far back one can go before Homebrew doesn't install anymore). Thanks for the check!

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants