Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add info about tap creation #15652

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

andy9a9
Copy link
Contributor

@andy9a9 andy9a9 commented Jul 8, 2023

Tap directories for furmulae/casks have to be created manually. Add additional step into docu for creating them.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?

Closes #15640

@Bo98 Bo98 requested a review from EricFromCanada July 9, 2023 02:47
Copy link
Member

@EricFromCanada EricFromCanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just adjusting some wording to clarify what the word "tap" means in this context.

docs/How-To-Open-a-Homebrew-Pull-Request.md Outdated Show resolved Hide resolved
docs/How-To-Open-a-Homebrew-Pull-Request.md Outdated Show resolved Hide resolved
Tap directories for furmulae/casks have to be created manually.

Signed-off-by: Andrej Valek <andy@skyrain.eu>
@EricFromCanada EricFromCanada merged commit 88e39d5 into Homebrew:master Jul 10, 2023
24 checks passed
@EricFromCanada
Copy link
Member

It's through contributions like yours that we've been able to run this project. Thanks, @andy9a9!

@andy9a9 andy9a9 deleted the docs/tap branch July 10, 2023 18:09
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing directories
2 participants