Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers 9.0 retry #2

Open
wants to merge 1 commit into
base: halium-9.0
Choose a base branch
from
Open

Headers 9.0 retry #2

wants to merge 1 commit into from

Conversation

Herrie82
Copy link

No description provided.

@Herrie82
Copy link
Author

@NotKit these headers from this PR are generated based on a clean repo-synced Halium 9.0 tree before any hybris-patches are applied. Changes seem to be mainly the nxp/nfc headers, but also there are some in other files. As per IRC/Telegram we have some issues on Mako with hwcomposer which seems to be due to header issues in your 9.0 header commit.

Happy to discuss with you together with @Tofee

@Tofee
Copy link

Tofee commented Jan 30, 2023

I just came across a crash in test_hwcomposer that I couldn't understand... until I remarked that HWC_NUM_DISPLAY_TYPES had the wrong value in our android-headers checkout.
The correct value for Halium-9.0 is "3": (see for instance https://github.com/LineageOS/android_hardware_libhardware/blob/lineage-16.0/include/hardware/hwcomposer_defs.h#L267 ) and not "9", which would correspond to a newer Android version.
Herrie's update looks more correct to me, but it's open to discussion @NotKit .

Tofee added a commit to Tofee/meta-smartphone-1 that referenced this pull request Feb 9, 2023
@Tofee
android-headers-halium: use correct branch
873dc4a 
The default branch has incorrect headers content, see PR
Halium/android-headers#2

Signed-off-by: Christophe Chapuis <chris.chapuis@gmail.com>
shr-project pushed a commit to shr-distribution/meta-smartphone that referenced this pull request Feb 12, 2023
@Tofee @shr-project
android-headers-halium: use correct branch
b01b0c3 
The default branch has incorrect headers content, see PR
Halium/android-headers#2

Signed-off-by: Christophe Chapuis <chris.chapuis@gmail.com>
shr-project pushed a commit to shr-distribution/meta-smartphone that referenced this pull request Feb 12, 2023
@Tofee @shr-project
android-headers-halium: use correct branch
f5bc58b 
The default branch has incorrect headers content, see PR
Halium/android-headers#2

Signed-off-by: Christophe Chapuis <chris.chapuis@gmail.com>
shr-project pushed a commit to shr-distribution/meta-smartphone that referenced this pull request Feb 12, 2023
@Tofee @shr-project
android-headers-halium: use correct branch
ef2b563 
The default branch has incorrect headers content, see PR
Halium/android-headers#2

Signed-off-by: Christophe Chapuis <chris.chapuis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Herrie82 @Tofee