Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-6282 new jkl zones #108

Merged
merged 3 commits into from
Apr 8, 2024
Merged

DT-6282 new jkl zones #108

merged 3 commits into from
Apr 8, 2024

Conversation

sharhio
Copy link
Contributor

@sharhio sharhio commented Apr 3, 2024

  • New area data for jyväskylä
  • Case independent zone field search

Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green coding: change zone key in data to 'Zone', instead of searching and lowercase mapping feature property keys in runtime again and again, everytime a user somewhere clicks a journey planner map. This will save millions of code iterations every month.

@sharhio
Copy link
Contributor Author

sharhio commented Apr 8, 2024

Green coding: change zone key in data to 'Zone', instead of searching and lowercase mapping feature property keys in runtime again and again, everytime a user somewhere clicks a journey planner map. This will save millions of code iterations every month.

Good point. This one was done out of frustration with the zones mysteriously not working. Will deal with it in some other way.

@vesameskanen vesameskanen merged commit 04e9952 into master Apr 8, 2024
1 check passed
@vesameskanen vesameskanen deleted the DT-6282 branch April 8, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants