-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy matrix folder from test scenario #531
base: olusanya
Are you sure you want to change the base?
Copy matrix folder from test scenario #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to make it clear, this will save you from hassle when using test data as you will not have to change the Results folder in the project settings to make model runs with test data work? But what if you want to use MockAssignment
with the full helmet data, but you do not have the matrices in the right directory? The model run will then happily continue, but you will then run into a problem of too small impedance matrices at a later stage.
raise NameError(msg) | ||
log.info("Matrices folder does not exist, copying the folder from test scenario") | ||
test_path = os.path.join(args.results_path,"test","Matrices") | ||
import shutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imports should be at the top of the module.
Yes, that was the idea, but indeed this does not work well with mock run of real Helmet data. I have to rethink this a bit. |
I removed myself from reviewers as this is still in draft phase. Please tag me if you have any questions or we need to discuss something, or mark me as reviewer when this is ready for review. 😊 |
It's one small step for mock run, one giant leap for testing? Or not so much, but at least should enable having multiple testing scenarios under different names without having to move things in the folders manually.