-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAL 2023 Car ownership #434
Draft
johpiip
wants to merge
16
commits into
olusanya
Choose a base branch
from
mal23-car-ownership
base: olusanya
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add text file dumping of link attributes with wkt coordinates
* Fix/noise zones (#450) * Print nodes to better debug errors * Print 5 meter noise buffers for negative values * Set `cross_traffic` minimum value to 0.01 * Add error message * Revert zone width change Co-authored-by: Jens West <jens.west@hsl.fi> * Update `HELMET_VERSION` (#451) * Speed up histogram incrementation by changing lookup method (#452) * Fix floating-point number error (#455) Co-authored-by: Jens West <jens.west@hsl.fi>
* Fix/noise zones (#450) * Print nodes to better debug errors * Print 5 meter noise buffers for negative values * Set `cross_traffic` minimum value to 0.01 * Add error message * Revert zone width change Co-authored-by: Jens West <jens.west@hsl.fi> * Update `HELMET_VERSION` (#451) * Speed up histogram incrementation by changing lookup method (#452) * Fix floating-point number error (#455) * Fix bicycle trips CBA (#463) Fix incorrect linking of bicycle trips in CBA Excel sheet that causes travel time saving of leisure trips being calculated based on work trips data. * Remove hard-coded area-based bounds from `Purpose` (#459) * Remove hard-coded area-based bounds from `Purpose` Introduce more general sub-bounds that can define separate parameters for arbitrary number of sub-regions instead of two * Generalize transit trips per month accordingly * Add helpful comment Co-authored-by: Jens West <jens.west@hsl.fi> Co-authored-by: Sami Mäkinen <47142755+samakinen@users.noreply.github.com> Co-authored-by: Jens West <jens.west@traficom.fi>
Merge `olusanya` to `mal23-car-ownership`
Pull changes from `olusanya`
Generalize sub-bound handling (#469)
Merge changes from `olusanya` to `mal23-car-ownership`
Bring changes from `olusanya` to `mal23-car-ownership`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is not meant to be merged to
olusanya
but I am creating a draft PR for discussion!This branch features setting car ownership growth via command line.
set_car_growth()
is cherry-picked frommal23
branch (conflicts are resolved so thatolusanya
version wins). Running several models via one run has been removed. Arguments controlling car ownership growth have been added to command line interface.