Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAL 2023 Car ownership #434

Draft
wants to merge 16 commits into
base: olusanya
Choose a base branch
from
Draft

MAL 2023 Car ownership #434

wants to merge 16 commits into from

Conversation

johpiip
Copy link
Contributor

@johpiip johpiip commented Feb 3, 2022

This branch is not meant to be merged to olusanya but I am creating a draft PR for discussion!

This branch features setting car ownership growth via command line. set_car_growth() is cherry-picked from mal23 branch (conflicts are resolved so that olusanya version wins). Running several models via one run has been removed. Arguments controlling car ownership growth have been added to command line interface.

@johpiip johpiip added the mal23 MAL 2023 impact assessment label Feb 3, 2022
West Jens and others added 5 commits February 4, 2022 12:42
johpiip and others added 7 commits July 5, 2022 17:10
* Fix/noise zones (#450)

* Print nodes to better debug errors

* Print 5 meter noise buffers for negative values

* Set `cross_traffic` minimum value to 0.01

* Add error message

* Revert zone width change

Co-authored-by: Jens West <jens.west@hsl.fi>

* Update `HELMET_VERSION` (#451)

* Speed up histogram incrementation by changing lookup method (#452)

* Fix floating-point number error (#455)

Co-authored-by: Jens West <jens.west@hsl.fi>
* Fix/noise zones (#450)

* Print nodes to better debug errors

* Print 5 meter noise buffers for negative values

* Set `cross_traffic` minimum value to 0.01

* Add error message

* Revert zone width change

Co-authored-by: Jens West <jens.west@hsl.fi>

* Update `HELMET_VERSION` (#451)

* Speed up histogram incrementation by changing lookup method (#452)

* Fix floating-point number error (#455)

* Fix bicycle trips CBA (#463)

Fix incorrect linking of bicycle trips in CBA Excel sheet that causes travel time saving of leisure trips being calculated based on work trips data.

* Remove hard-coded area-based bounds from `Purpose` (#459)

* Remove hard-coded area-based bounds from `Purpose`

Introduce more general sub-bounds that can define separate parameters
for arbitrary number of sub-regions instead of two

* Generalize transit trips per month accordingly

* Add helpful comment

Co-authored-by: Jens West <jens.west@hsl.fi>
Co-authored-by: Sami Mäkinen <47142755+samakinen@users.noreply.github.com>
Co-authored-by: Jens West <jens.west@traficom.fi>
Merge `olusanya` to `mal23-car-ownership`
Pull changes from `olusanya`
Generalize sub-bound handling (#469)
Merge changes from `olusanya` to `mal23-car-ownership`
Bring changes from `olusanya` to `mal23-car-ownership`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mal23 MAL 2023 impact assessment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant