feat: specify time zone by name without time zone data #4782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In the configuration file, use the new variable
timezone
instead of the oldtimezoneData
variable.Reason:
According to the Moment.js documentation, the Node.js variant includes all timezone data. So there is no need to manually set the timezone data. It is enough to just specify the timezone name, e.g.
Europe/Helsinki
.Benefits:
timezoneData: 'Europe/Berlin'
instead ofNotes:
I tested this locally to be working with the
Helsinki
andBerlin
time zones. But I haven't added any new test cases.I am looking forward to your feedback regarding the proposed changes!
Pull Request Check List
Review