Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: GraphQL queries #4621

Draft
wants to merge 17 commits into
base: v3
Choose a base branch
from
Draft

Typescript: GraphQL queries #4621

wants to merge 17 commits into from

Conversation

joonaojapalo
Copy link
Contributor

Note, this depends on PR #4619.

Proposed Changes

  • relay-compiler, react-relay and their essential dependencies updated to version 14 (including package @digitransit-search-util/digitransit-search-util-query-utils)
  • Relay 14 operates directly on GraphQL Schema file (schema.graphql). A script to fetch this from OpenTripPlanner GH repo is added.
  • New package.json script graphql:schema:update updates GraphQL schema files for both app and @digitransit-search-util/digitransit-search-util-query-utils.
  • New API for relay-runtime/fetchQuery() returns Observable instead of Promise. Fixed by conversion via Observable.toPromise() method.

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@joonaojapalo joonaojapalo marked this pull request as draft September 13, 2022 06:18
@joonaojapalo joonaojapalo changed the title Compile GraphQL queries to typescript Typescript: GraphQL queries Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant