Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 32-bit CI test for linux #4996

Closed
wants to merge 1 commit into from
Closed

Add 32-bit CI test for linux #4996

wants to merge 1 commit into from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Oct 22, 2024

close #4921

derobins
derobins reviewed Oct 22, 2024
View reviewed changes
.github/workflows/i386-alp.yml
on:
workflow_dispatch:
schedule:
- cron: "6 0 * * *"
Copy link
Member

@derobins derobins Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why cron and not PR? Does it take a long time to run? Also, anything that isn't a PR check should probably get a badge so it's easy to see when it fails.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to the daily-build workflow instead?

derobins
derobins approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@derobins derobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This is mainly so we can check out warnings on CDash.

@derobins derobins added Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality Merge - To 2.0 This needs to be merged to HDF5 2.0 labels Oct 22, 2024
byrnHDF
byrnHDF reviewed Oct 23, 2024
View reviewed changes
.github/workflows/i386-alp.yml
libgit2-dev
cmake
- name: run script
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to follow the cmake-script.yml file as a template instead of reinventing the workflows every time! Makes it so much harder to maintain.

byrnHDF
byrnHDF requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the existing workflows as templates (suggest improvements)

@hyoklee hyoklee closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF requested changes

@derobins derobins derobins approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Merge - To 2.0 This needs to be merged to HDF5 2.0 Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 32-bit CI test for linux
3 participants
@hyoklee @derobins @byrnHDF