Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move h5_test_init() calls after MPI_Init #4988

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jhendersonHDF
Copy link
Collaborator

Parallel HDF5 attempts to create a destructor attribute on the MPI Communicator object
MPI_COMM_SELF when the library initializes. This is to ensure that proper shutdown of the
library occurs during calls to MPI_Finalize() so that the library doesn't unintentionally make
use of MPI objects after MPI has been finalized. If MPI has not been initialized with a call to
MPI_Init() before HDF5 is initialized, the library will be unable to register its destructor attribute
on MPI_COMM_SELF and will be unable to properly shut down the library in some cases.

@jhendersonHDF jhendersonHDF added Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality Merge - To 2.0 This needs to be merged to HDF5 2.0 labels Oct 21, 2024
@derobins derobins merged commit 877c6d8 into HDFGroup:develop Oct 21, 2024
60 checks passed
qkoziol pushed a commit to qkoziol/hdf5 that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Merge - To 2.0 This needs to be merged to HDF5 2.0 Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants