Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix DEFAULT_API_VERSION with HDF5_ in CMake #4982

Closed
wants to merge 1 commit into from
Closed

Prefix DEFAULT_API_VERSION with HDF5_ in CMake #4982

wants to merge 1 commit into from

Conversation

derobins
Copy link
Member

All other HDF5 library CMake options are prefixed with HDF5_

@derobins
Renamed DEFAULT_API_VERSION to HDF5_DEFAULT_API_VERSION in CMake
742f078 
All other HDF5 library CMake options are prefixed with HDF5_
@derobins derobins added Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Merge - To 2.0 This needs to be merged to HDF5 2.0 labels Oct 19, 2024
@derobins
Copy link
Member Author

I did not bother to update the versions to 2.0, etc. since that should be done in a separate PR

@derobins derobins changed the title Renamed DEFAULT_API_VERSION to HDF5_DEFAULT_API_VERSION in CMake Prefix DEFAULT_API_VERSION with HDF5_ in CMake Oct 19, 2024
byrnHDF
byrnHDF requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT_API_VERSION has at least 43 references in code that needs updated.

@byrnHDF byrnHDF mentioned this pull request Oct 21, 2024
Merged
@byrnHDF
Copy link
Contributor

byrnHDF commented Oct 21, 2024

Superceded by #4990

@derobins derobins closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF requested changes

@qkoziol qkoziol qkoziol approved these changes

@bmribler bmribler bmribler approved these changes

@mattjala mattjala mattjala approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Merge - To 2.0 This needs to be merged to HDF5 2.0 Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@derobins @byrnHDF @qkoziol @bmribler @mattjala