Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for native zlib-ng in the library and compression references #4935

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Oct 7, 2024

No description provided.

@byrnHDF byrnHDF added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - C Library Core C library issues (usually in the src directory) Component - Tools Command-line tools like h5dump, includes high-level tools Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality Merge - To 2.0 This needs to be merged to HDF5 2.0 labels Oct 7, 2024
@byrnHDF byrnHDF self-assigned this Oct 7, 2024
lrknox
lrknox previously approved these changes Oct 8, 2024
@ajelenak
Copy link
Contributor

Fails library build on my laptop:

[1005/2964] Building C object tools/test/perform/CMakeFiles/zip_perf.dir/zip_perf.c.o
FAILED: tools/test/perform/CMakeFiles/zip_perf.dir/zip_perf.c.o 
/Users/ajelenak/micromamba/envs/venv-libhdf5/bin/arm64-apple-darwin20.0.0-clang -DH5_BUILT_AS_DYNAMIC_LIB -I/Users/ajelenak/Documents/example-venv-libhdf5/hdf5-develop-add-zlibng/test -I/Users/ajelenak/Documents/example-venv-libhdf5/hdf5-develop-add-zlibng/src -I/Users/ajelenak/Documents/example-venv-libhdf5/hdf5-develop-add-zlibng/src/H5FDsubfiling -I/Users/ajelenak/Documents/example-venv-libhdf5/hdf5-develop-add-zlibng/build/src -I/Users/ajelenak/Documents/example-venv-libhdf5/hdf5-develop-add-zlibng/build/tools/lib -I/Users/ajelenak/Documents/example-venv-libhdf5/hdf5-develop-add-zlibng/tools/lib -isystem /Users/ajelenak/micromamba/envs/venv-libhdf5/zlib-ng/include -std=c99 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem /Users/ajelenak/micromamba/envs/venv-libhdf5/include -O3 -DNDEBUG -std=gnu99 -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -fPIE -MD -MT tools/test/perform/CMakeFiles/zip_perf.dir/zip_perf.c.o -MF tools/test/perform/CMakeFiles/zip_perf.dir/zip_perf.c.o.d -o tools/test/perform/CMakeFiles/zip_perf.dir/zip_perf.c.o -c /Users/ajelenak/Documents/example-venv-libhdf5/hdf5-develop-add-zlibng/tools/test/perform/zip_perf.c
/Users/ajelenak/Documents/example-venv-libhdf5/hdf5-develop-add-zlibng/tools/test/perform/zip_perf.c:171:14: error: call to undeclared function 'zng_compress2'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    int rc = zng_compress2(dest, destLen, source, sourceLen, compress_level);
             ^
/Users/ajelenak/Documents/example-venv-libhdf5/hdf5-develop-add-zlibng/tools/test/perform/zip_perf.c:171:14: note: did you mean 'uncompress2'?
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/zlib.h:1296:21: note: 'uncompress2' declared here
ZEXTERN int ZEXPORT uncompress2 OF((Bytef *dest,   uLongf *destLen,
                    ^
1 error generated.

@lrknox lrknox dismissed their stale review October 16, 2024 11:06

Build failure on Aleksandar's laptop should be investigated and addressed.

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Oct 23, 2024

Because zip_perf is a test program in tools it doesn't seem to have access to the H5_HAVE_ZLIBNG_H define needed to switch API calls.

@ajelenak
Copy link
Contributor

ajelenak commented Oct 23, 2024

Builds and all but one test pass on my laptop. The only failing test is H5TEST-dt_arith but it is unrelated to this.

@lrknox lrknox merged commit 1b72a1b into HDFGroup:develop Oct 23, 2024
62 checks passed
@byrnHDF byrnHDF deleted the develop-add-zlibng branch October 25, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Component - Tools Command-line tools like h5dump, includes high-level tools Merge - To 2.0 This needs to be merged to HDF5 2.0 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
Status: Needs Merged
Development

Successfully merging this pull request may close these issues.

4 participants