-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for native zlib-ng in the library and compression references #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Priority - 1. High 🔼
These are important issues that should be resolved in the next release
Component - C Library
Core C library issues (usually in the src directory)
Component - Tools
Command-line tools like h5dump, includes high-level tools
Component - Build
CMake, Autotools
Type - Improvement
Improvements that don't add a new feature or functionality
Merge - To 2.0
This needs to be merged to HDF5 2.0
labels
Oct 7, 2024
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
October 7, 2024 15:37
lrknox
previously approved these changes
Oct 8, 2024
Fails library build on my laptop:
|
lrknox
dismissed
their stale review
October 16, 2024 11:06
Build failure on Aleksandar's laptop should be investigated and addressed.
Because zip_perf is a test program in tools it doesn't seem to have access to the H5_HAVE_ZLIBNG_H define needed to switch API calls. |
Builds and all but one test pass on my laptop. The only failing test is H5TEST-dt_arith but it is unrelated to this. |
ajelenak
approved these changes
Oct 23, 2024
lrknox
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Build
CMake, Autotools
Component - C Library
Core C library issues (usually in the src directory)
Component - Tools
Command-line tools like h5dump, includes high-level tools
Merge - To 2.0
This needs to be merged to HDF5 2.0
Priority - 1. High 🔼
These are important issues that should be resolved in the next release
Type - Improvement
Improvements that don't add a new feature or functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.