Skip to content

Commit

Permalink
Always check for __attribute__() in CMake (#4980)
Browse files Browse the repository at this point in the history
The CMake compiler checks skip checking for things like __attribute__()
on Windows. Now that Visual Studio can use clang, we should be checking
for this, even on non-MinGW Windows.
  • Loading branch information
derobins authored Oct 20, 2024
1 parent 7f1e492 commit ee6c2ee
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions config/cmake/ConfigureChecks.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -437,16 +437,14 @@ endif ()
#-----------------------------------------------------------------------------
# Check a bunch of other functions
#-----------------------------------------------------------------------------
if (MINGW OR NOT WINDOWS)
foreach (other_test
HAVE_ATTRIBUTE
HAVE_BUILTIN_EXPECT
PTHREAD_BARRIER
HAVE_SOCKLEN_T
foreach (other_test
HAVE_ATTRIBUTE
HAVE_BUILTIN_EXPECT
PTHREAD_BARRIER
HAVE_SOCKLEN_T
)
HDF_FUNCTION_TEST (${other_test})
endforeach ()
endif ()
HDF_FUNCTION_TEST (${other_test})
endforeach ()

# ----------------------------------------------------------------------
# Set the flag to indicate that the machine can handle converting
Expand Down

0 comments on commit ee6c2ee

Please sign in to comment.