Skip to content

Commit

Permalink
Remove the high-level GIF tools (#4976)
Browse files Browse the repository at this point in the history
The high-level GIF tools, h52gif and gif2h5, have unfixed CVE issues
(with no proof-of-concept files). They are not critical tools, are not
well maintained, and are an odd fit for building with the library.
Because of this, they have been removed. We may move them to a separate
repository in the future.
  • Loading branch information
derobins authored Oct 18, 2024
1 parent 478c7d1 commit bb56611
Show file tree
Hide file tree
Showing 24 changed files with 13 additions and 2,762 deletions.
25 changes: 0 additions & 25 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,6 @@ AC_LANG_POP(C++)
## library is disabled.
AC_SUBST([HDF5_HL])
AC_SUBST([HDF5_HL_TOOLS])
AC_SUBST([HDF5_HL_GIF_TOOLS])

## The high-level library and high-level tools are enabled unless the build mode
## is clean.
Expand Down Expand Up @@ -1477,27 +1476,6 @@ AC_ARG_ENABLE([tools],

AC_MSG_RESULT([$HDF5_TOOLS])

## ----------------------------------------------------------------------
## Check if they would like to disable building the high-level GIF
## tools (they have unfixed CVE issues)
##

AC_MSG_CHECKING([if the high-level GIF tools are enabled])
AC_ARG_ENABLE([hlgiftools],
[AS_HELP_STRING([--enable-hlgiftools],
[Enable the high-level GIF tools. NOTE: These have unfixed CVE issues!
[default=no]
])],
[HDF5_HL_GIF_TOOLS=$enableval])

if test "X-$HDF5_TOOLS" = "X-yes" -a "X-$HDF5_HL" = "X-yes" -a "X-$HDF5_HL_GIF_TOOLS" = "X-yes"; then
AC_MSG_RESULT([yes])
else
AC_MSG_RESULT([no])
HDF5_HL_GIF_TOOLS="no"
fi


## ----------------------------------------------------------------------
## Check if they would like to enable building doxygen files
##
Expand Down Expand Up @@ -4411,7 +4389,6 @@ AM_CONDITIONAL([BUILD_HDF5_HL_CONDITIONAL], [test "X$HDF5_HL" = "Xyes"])
AM_CONDITIONAL([BUILD_TESTS_CONDITIONAL], [test "X$HDF5_TESTS" = "Xyes"])
AM_CONDITIONAL([BUILD_TESTS_PARALLEL_CONDITIONAL], [test -n "$TESTPARALLEL"])
AM_CONDITIONAL([BUILD_TOOLS_CONDITIONAL], [test "X$HDF5_TOOLS" = "Xyes"])
AM_CONDITIONAL([BUILD_TOOLS_HL_GIF_CONDITIONAL], [test "X$HDF5_HL_GIF_TOOLS" = "Xyes"])
AM_CONDITIONAL([BUILD_DOXYGEN_CONDITIONAL], [test "X$HDF5_DOXYGEN" = "Xyes"])

## ----------------------------------------------------------------------
Expand Down Expand Up @@ -4619,8 +4596,6 @@ AC_CONFIG_FILES([Makefile
hl/test/Makefile
hl/test/H5srcdir_str.h
hl/tools/Makefile
hl/tools/gif2h5/Makefile
hl/tools/gif2h5/h52giftest.sh
hl/tools/h5watch/Makefile
hl/tools/h5watch/testh5watch.sh
hl/examples/Makefile
Expand Down
8 changes: 0 additions & 8 deletions hl/tools/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
cmake_minimum_required (VERSION 3.18)
project (HDF5_HL_TOOLS C)

#-----------------------------------------------------------------------------
#-- Option to build the High level GIF Tools
#-----------------------------------------------------------------------------
option (HDF5_BUILD_HL_GIF_TOOLS "Build HDF5 HL GIF Tools" OFF)
if (HDF5_BUILD_HL_GIF_TOOLS)
add_subdirectory (gif2h5)
endif ()

add_subdirectory (h5watch)
8 changes: 1 addition & 7 deletions hl/tools/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,7 @@

include $(top_srcdir)/config/commence.am

if BUILD_TOOLS_HL_GIF_CONDITIONAL
TOOLS_GIF_DIR = gif2h5
else
TOOLS_GIF_DIR =
endif

# All subdirectories
SUBDIRS=h5watch $(TOOLS_GIF_DIR)
SUBDIRS=h5watch

include $(top_srcdir)/config/conclude.am
107 changes: 0 additions & 107 deletions hl/tools/gif2h5/CMakeLists.txt

This file was deleted.

76 changes: 0 additions & 76 deletions hl/tools/gif2h5/CMakeTests.cmake

This file was deleted.

50 changes: 0 additions & 50 deletions hl/tools/gif2h5/Makefile.am

This file was deleted.

Loading

0 comments on commit bb56611

Please sign in to comment.