Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove HDF-EOS2 CI action" #781

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Oct 7, 2024

Reverts #751

@schwehr
Copy link
Collaborator

schwehr commented Oct 7, 2024

It would be good to explain in detail why that removal should now be reverted.

@derobins
Copy link
Member

derobins commented Oct 7, 2024

It would be good to explain in detail why that removal should now be reverted.

It was only removed because HDF-EOS2/5 went behind a login wall, causing the tests to fail when we couldn't get the code.

Copy link
Member

@derobins derobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this test failing? Why is the HDF-EOS2 compile barfing on missing C standard library calls?

@lrknox
Copy link
Collaborator

lrknox commented Oct 10, 2024

Why is this test failing? Why is the HDF-EOS2 compile barfing on missing C standard library calls?

The (first) error:
SetupSwath.c:97:38: error: ‘NC_UNLIMITED’ undeclared (first use in this function); did you mean ‘SD_UNLIMITED’?
97 | status = SWdefdim(SWid, "Unlim", NC_UNLIMITED);

NC_UNLIMITED was previously defined here:
mfhdf/src/netcdf.h.in:#define NC_UNLIMITED 0L

File no longer exists - probably removed with netcdf 2.3.2 removal.

HDFEOS2 can't build with current HDF4 master. Current hdfeos2 code will require HDF4.3.0 or earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants