-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename private headers <foo>_priv.h #573
Conversation
This will make it easy to distinguish what is private and what is public. Also: * Removed unused hdf/src/src.inc and mfhdf/fortran/common.inc files * Removed mfhdfi.h after moving the enum it contained to mfhdf.h
Missing stdlib.h in a lot of places
# release_notes/RELEASE.txt, configure.in, | ||
# and config/cmake/scripts/HDF4config.cmake. | ||
# The paths to README.md, release_notes/RELEASE.txt, configure.ac, | ||
# and config/cmake/scripts/HDF4config.cmake | ||
# files are always from the directory two levels above hfile.h. | ||
# files are always from the directory two levels above hfile_priv.h. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my next PR, I plan to put the version macros in hdf.h
#include <string.h> | ||
|
||
#include <jni.h> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reordered the headers so they are in OS/C --> JNI --> Local order and put them outside the extern C block
This will make it easy to distinguish public v. private symbols.
Also: