Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to allow tools type selection and naming #565

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

byrnHDF
Copy link
Collaborator

@byrnHDF byrnHDF commented Feb 19, 2024

No description provided.

@byrnHDF byrnHDF added Component - Build CMake, Autotools Component - Tools Command-line tools like dumper and hdiff Component - Testing Test code, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality Priority - 1. High 🔼 These are important issues that should be resolved in the next release labels Feb 19, 2024
@byrnHDF byrnHDF self-assigned this Feb 19, 2024
@derobins
Copy link
Member

Needs a release note!

@derobins
Copy link
Member

Ideally, what we want is basically how the Autotools work:

  • If you build static, you get tools that are statically linked to the HDF4 libraries and named normally
  • If you build shared, you get tools that are dynamically linked to the HDF4 libraries and named normally
  • If you build static + shared, you only get dynamically linked tools, which are named normally
  • There should be an option to build tools that are statically linked to the HDF4 libraries (and named normally), even when building shared (some people want to be able to copy the tools around)
  • No tool should ever be named foo-static or foo-shared

@derobins derobins merged commit 91ac289 into HDFGroup:master Feb 20, 2024
38 checks passed
@byrnHDF byrnHDF deleted the master-tools-names branch February 21, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build CMake, Autotools Component - Testing Test code, GitHub workflows Component - Tools Command-line tools like dumper and hdiff Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants