Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -Wdouble-promotion issues #436

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix -Wdouble-promotion issues #436

merged 1 commit into from
Sep 13, 2023

Conversation

derobins
Copy link
Member

No description provided.

@derobins derobins added Component - C Library Core C library issues Component - Tools Command-line tools like dumper and hdiff Component - netCDF netCDF interface and nc* command-line tools Component - Testing Test code, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. labels Sep 13, 2023
@derobins
Copy link
Member Author

derobins commented Sep 13, 2023 •
edited
Loading

Most of this just involved casting floats to double in printf (and related) statements. There were only a few places where I had to address actual promotions, and most of those just needed casts.

@derobins derobins merged commit dc049a7 into HDFGroup:master Sep 13, 2023
44 checks passed
@derobins derobins deleted the double_promotion_warnings branch March 3, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox lrknox approved these changes

@bmribler bmribler bmribler approved these changes

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@schwehr schwehr Awaiting requested review from schwehr schwehr is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues Component - netCDF netCDF interface and nc* command-line tools Component - Testing Test code, GitHub workflows Component - Tools Command-line tools like dumper and hdiff Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derobins @lrknox @bmribler