-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dfi.h from the source #431
Conversation
*NOTE* This is a deployed header file! This header file is declared internal, but is unused in the library and is undocumented in the RM, UG, and DG.
Some of the macros in this file are used in other, unused macros. I will track those down and remove them as well. Update: DONE (ready for review) |
@@ -52,8 +52,7 @@ | |||
* Note that rseq does its own compression, because that is part of | |||
* the interactive color raster protocol | |||
* The space needed for compression and decompression can be allocated | |||
* statically or dynamically, depending on the DF_DYNAMIC flag, and | |||
* for entire image or part of it (reused) depending on availability | |||
* for the entire image or part of it (reused) depending on availability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always dynamic in the code below and DF_DYNAMIC is not used anywhere
/*----------------------------------------------------------------------------- | ||
* File: dfi.h | ||
* Purpose: HDF internal header file | ||
* Invokes: stdio.h, sys/file.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note "internal"...
return (ret); \ | ||
} \ | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are also unused and invoke the dfi.h macros. Since they are located in a C file, there is no risk if we remove them.
@@ -116,7 +116,6 @@ typedef short hdf_file_t; | |||
#define HI_SEEK(x, y) mlseek(x, (int32)y, 0) | |||
#define HI_SEEKEND(x) mlseek(x, 0L, 2) | |||
#define HI_TELL(x) mlseek(x, 0L, 1) | |||
#define DF_OPENERR(f) ((f) == -1) | |||
#define OPENERR(f) (f < 0) | |||
#endif /* FILELIB == MACIO */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove code protected by MACIO in a separate commit. I don't think we need to support MacOS 9 in 2023...
|
||
* dfi.h - Declared private, unused, undocumented in UG/RM/DG, has been | ||
removed from the library entirely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll expand this list in future commits as we move private headers out of the deploy list
NOTE This is a deployed header file!
This header file is declared internal, but is unused in the library and is undocumented in the RM, UG, and DG.