Remove dfi.h from the source #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*NOTE* This is a deployed header file! This header file is declared internal, but is unused in the library and is undocumented in the RM, UG, and DG.
derobins
added
Component - C Library
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
|
Some of the macros in this file are used in other, unused macros. I will track those down and remove them as well. Update: DONE (ready for review) |
derobins
commented
Sep 12, 2023
| @@ -52,8 +52,7 @@ | |||
| * Note that rseq does its own compression, because that is part of | |||
| * the interactive color raster protocol | |||
| * The space needed for compression and decompression can be allocated | |||
| * statically or dynamically, depending on the DF_DYNAMIC flag, and | |||
| * for entire image or part of it (reused) depending on availability | |||
| * for the entire image or part of it (reused) depending on availability | |||
There was a problem hiding this comment.
It's always dynamic in the code below and DF_DYNAMIC is not used anywhere
derobins
commented
Sep 12, 2023
| /*----------------------------------------------------------------------------- | ||
| * File: dfi.h | ||
| * Purpose: HDF internal header file | ||
| * Invokes: stdio.h, sys/file.h |
derobins
commented
Sep 12, 2023
| return (ret); \ | ||
| } \ | ||
| } | ||
|
|
There was a problem hiding this comment.
These are also unused and invoke the dfi.h macros. Since they are located in a C file, there is no risk if we remove them.
derobins
commented
Sep 12, 2023
| @@ -116,7 +116,6 @@ typedef short hdf_file_t; | |||
| #define HI_SEEK(x, y) mlseek(x, (int32)y, 0) | |||
| #define HI_SEEKEND(x) mlseek(x, 0L, 2) | |||
| #define HI_TELL(x) mlseek(x, 0L, 1) | |||
| #define DF_OPENERR(f) ((f) == -1) | |||
| #define OPENERR(f) (f < 0) | |||
| #endif /* FILELIB == MACIO */ | |||
There was a problem hiding this comment.
I'll remove code protected by MACIO in a separate commit. I don't think we need to support MacOS 9 in 2023...
derobins
commented
Sep 12, 2023
|
|
||
| * dfi.h - Declared private, unused, undocumented in UG/RM/DG, has been | ||
| removed from the library entirely. |
There was a problem hiding this comment.
I'll expand this list in future commits as we move private headers out of the deploy list
bmribler
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE This is a deployed header file!
This header file is declared internal, but is unused in the library and is undocumented in the RM, UG, and DG.