Skip to content

Commit

Permalink
Check current version before remove files (#745)
Browse files Browse the repository at this point in the history
* Fix var reference, need outputs
  • Loading branch information
byrnHDF authored Aug 14, 2024
1 parent 5b66b31 commit 6505142
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/cmake-ctest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
name: Check Secrets exists
runs-on: ubuntu-latest
outputs:
sign-state: ${{ steps.set-signing-state.BINSIGN }}
sign-state: ${{ steps.set-signing-state.outputs.BINSIGN }}
steps:
- name: Identify Signing Status
id: set-signing-state
Expand All @@ -53,13 +53,15 @@ jobs:
run: |
if [[ '${{ env.signing_secret }}' == '' ]]
then
SIGN_VAL=$(echo "false")
SIGN_VAL=$(echo 'notexists')
else
SIGN_VAL=$(echo "true")
SIGN_VAL=$(echo 'exists')
fi
echo "BINSIGN=$SIGN_VAL" >> $GITHUB_OUTPUT
shell: bash

- run: echo "signing is ${{ steps.set-signing-state.outputs.BINSIGN }}."

build_and_test_win:
# Windows w/ MSVC + CMake
#
Expand Down Expand Up @@ -134,7 +136,7 @@ jobs:
file-digest: SHA256
timestamp-rfc3161: http://timestamp.acs.microsoft.com
timestamp-digest: SHA256
if: ${{ needs.check-secret.outputs.sign-state == 'true' }}
if: ${{ needs.check-secret.outputs.sign-state == 'exists' }}

- name: Publish binary (Windows)
id: publish-ctest-binary
Expand Down Expand Up @@ -489,7 +491,7 @@ jobs:
file-digest: SHA256
timestamp-rfc3161: http://timestamp.acs.microsoft.com
timestamp-digest: SHA256
if: ${{ needs.check-secret.outputs.sign-state == 'true' }}
if: ${{ needs.check-secret.outputs.sign-state == 'exists' }}

- name: Publish binary (Windows_intel)
id: publish-ctest-binary
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/daily-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,5 @@ jobs:
file_base: ${{ needs.get-old-names.outputs.hdf4-name }}
use_tag: snapshot
use_environ: snapshots
if: ${{ needs.call-workflow-tarball.outputs.has_changes == 'true' }}
if: ${{ (needs.call-workflow-tarball.outputs.has_changes == 'true') && (needs.get-old-names.outputs.hdf4-name != needs.call-workflow-tarball.outputs.file_base) }}

0 comments on commit 6505142

Please sign in to comment.