Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-attribute API #202

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Multi-attribute API #202

merged 8 commits into from
Jun 7, 2024

Conversation

mattjala
Copy link
Contributor

No description provided.

@mattjala mattjala requested a review from jreadey May 17, 2024 20:07
@mattjala mattjala self-assigned this May 17, 2024
@jreadey
Copy link
Member

jreadey commented May 20, 2024

It would be nice to support getting an arbitrary set of attributes by an list of names.

@jreadey
Copy link
Member

jreadey commented May 21, 2024

Can you add getting attributes based on a glob pattern? Or would that be another PR?

@mattjala
Copy link
Contributor Author

Can you add getting attributes based on a glob pattern? Or would that be another PR?

Glob patterns are already supported - see test_get_multiple

h5pyd/_hl/attrs.py Show resolved Hide resolved
h5pyd/_hl/attrs.py Outdated Show resolved Hide resolved
"""
if use_cache and (pattern or limit or marker):
raise ValueError("use_cache cannot be used with pattern, limit, or marker parameters")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the effect of use_cache? Doesn't seem like it's really being used for anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was initially used to stop the cache from being used with requests that have parameters which affect the result - this is now done in the HttpConn. It can be removed now

h5pyd/_hl/attrs.py Outdated Show resolved Hide resolved
h5pyd/_hl/attrs.py Outdated Show resolved Hide resolved
h5pyd/_hl/attrs.py Show resolved Hide resolved
h5pyd/_hl/serverinfo.py Outdated Show resolved Hide resolved
@jreadey jreadey merged commit c56e40b into HDFGroup:master Jun 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants