Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overriding reference data path #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jchorl
Copy link

@jchorl jchorl commented Jul 29, 2024

Hi!

Thanks for the great tool.

2 modifications here:

  1. Allow overriding the ref data path for custom databases
  2. Stop using shell=True for subprocess.run. With the current setup, if your input file was named $(rm -rf / --no-preserve-root; echo "foo.txt") (uncommon, but possible!), you'd have a real bad time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant