Skip to content

Commit

Permalink
Don't mutate user settings
Browse files Browse the repository at this point in the history
Fixes #1067
Closes #1022
  • Loading branch information
dcsaszar committed Aug 3, 2024
1 parent 2cb0d07 commit e31ed5b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/cli/src/collect/node-runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class LighthouseRunner {
* @return {{args: string[], cleanupFn: () => void}}
*/
static computeArgumentsAndCleanup(url, options) {
const settings = options.settings || {};
const settings = {...options.settings};
const chromeFlags = options.settings && options.settings.chromeFlags;
let chromeFlagsAsString = chromeFlags || '';
if (!options.headful) chromeFlagsAsString += ' --headless=new';
Expand Down

0 comments on commit e31ed5b

Please sign in to comment.