refactor: Rewrite applying extensions #365
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the currently main 4.x issue
reload
instead ofnew
fixes that but i havent actually checked if thats trueclass_name
#338supersedes fix: non-static func call on(already merged anyway)InheritanceSorting
#363how this works:
extends
ignores resource cache, which is whattake_over_path
overrides, it reads only from packs or the file systemextends
in the extension scripts is patched to instead extend the script previous in the mod hierarchy, down to the copied original filetake_over_path
didnt seem to work for thismod (overwritten original) > mod > mod > ... > copied original
i didnt test much, especially with dependencies, but for a simple use case of a couple mods this seems to be working
also please squash when merging lol
current issues: