Deprecate direct commandline scripts invocation and exclude nonsense ones

CHANGELOG.md

@@ -78,6 +78,7 @@ The table below shows which release corresponds to each branch, and what date th
 - [#2327][2327] Add basic support to debug processes on Windows
 - [#2322][2322] Add basic RISCV64 shellcraft support
 - [#2330][2330] Change `context.newline` when setting `context.os` to `"windows"`
+- [#2364][2364] Deprecate direct commandline scripts invocation and exclude nonsense ones
 - [#2389][2389] Fix passing bytes to `context.log_file` and `crc.BitPolynom`
 - [#2391][2391] Fix error message when passing invalid kwargs to `xor`
 - [#2376][2376] Return buffered data on first EOF in tube.readline()
@@ -90,6 +91,7 @@ The table below shows which release corresponds to each branch, and what date th
 [2327]: https://github.com/Gallopsled/pwntools/pull/2327
 [2322]: https://github.com/Gallopsled/pwntools/pull/2322
 [2330]: https://github.com/Gallopsled/pwntools/pull/2330
+[2364]: https://github.com/Gallopsled/pwntools/pull/2364
 [2389]: https://github.com/Gallopsled/pwntools/pull/2389
 [2391]: https://github.com/Gallopsled/pwntools/pull/2391
 [2376]: https://github.com/Gallopsled/pwntools/pull/2376

pwnlib/commandline/common.py

@@ -30,3 +30,10 @@ def main(file=sys.argv[0]):
     name = os.path.splitext(os.path.basename(file))[0]
     sys.argv.insert(1, name)
     pwnlib.commandline.main.main()
+
+def deprecated_main():
+    file=sys.argv[0]
+    name = os.path.splitext(os.path.basename(file))[0]
+    import warnings
+    warnings.warn("The '%s' command is deprecated and will be removed in a future version. Please use 'pwn %s' instead." % (name, name), DeprecationWarning, stacklevel=2)
+    main(file)

setup.py

@@ -35,10 +35,10 @@
     filename = os.path.basename(filename)
     filename, ext = os.path.splitext(filename)
 
-    if ext != '.py' or '__init__' in filename:
+    if ext != '.py' or filename in ('__init__', 'common', 'main', 'update', 'version'):
         continue
 
-    script = '%s=pwnlib.commandline.common:main' % filename
+    script = '%s=pwnlib.commandline.common:deprecated_main' % filename
     if not flag:
         console_scripts.append(script)
 
@@ -78,6 +78,5 @@
         ] + templates,
     },
     entry_points = {'console_scripts': console_scripts},
-    scripts              = glob.glob("bin/*"),
     **compat
 )