Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove permission to manage API integration #2053

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −20
Open

remove permission to manage API integration #2053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7db678d
remove permsision to manage API integration
Oct 21, 2024
e2020c1
remove permsision to manage API integration
Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/utils/user_permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
("send_messages", "Send messages"),
("manage_templates", "Add and edit templates"),
("manage_service", "Manage settings, team and usage"),
("manage_api_keys", "Manage API integration"),
)


Expand Down
20 changes: 3 additions & 17 deletions tests/app/main/views/test_manage_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
"Can See dashboard "
"Can Send messages "
"Can Add and edit templates "
"Can Manage settings, team and usage "
"Can Manage API integration"
"Can Manage settings, team and usage"
),
True,
),
Expand Down Expand Up @@ -302,7 +301,6 @@ def test_service_without_caseworking_doesnt_show_admin_vs_caseworker(
assert permission_checkboxes[1]["value"] == "send_messages"
assert permission_checkboxes[2]["value"] == "manage_templates"
assert permission_checkboxes[3]["value"] == "manage_service"
assert permission_checkboxes[4]["value"] == "manage_api_keys"


@pytest.mark.parametrize(
Expand Down Expand Up @@ -386,7 +384,6 @@ def test_user_with_no_mobile_number_cant_be_set_to_sms_auth(
("send_messages", True),
("manage_templates", True),
("manage_service", True),
("manage_api_keys", True),
],
),
(
Expand All @@ -397,7 +394,6 @@ def test_user_with_no_mobile_number_cant_be_set_to_sms_auth(
("send_messages", False),
("manage_templates", False),
("manage_service", False),
("manage_api_keys", False),
],
),
],
Expand All @@ -415,7 +411,7 @@ def test_should_show_page_for_one_user(
page = client_request.get(endpoint, service_id=SERVICE_ONE_ID, **extra_args)
checkboxes = page.select("input[type=checkbox]")

assert len(checkboxes) == 5
assert len(checkboxes) == 4

for index, expected in enumerate(expected_checkboxes):
expected_input_value, expected_checked = expected
Expand Down Expand Up @@ -478,15 +474,13 @@ def test_should_not_show_page_for_non_team_member(
"send_messages",
"manage_templates",
"manage_service",
"manage_api_keys",
]
},
{
"view_activity",
"send_messages",
"manage_service",
"manage_templates",
"manage_api_keys",
},
),
(
Expand Down Expand Up @@ -658,7 +652,6 @@ def test_cant_edit_user_folder_permissions_for_platform_admin_users(
platform_admin_user["id"],
SERVICE_ONE_ID,
permissions={
"manage_api_keys",
"manage_service",
"manage_templates",
"send_messages",
Expand Down Expand Up @@ -710,7 +703,6 @@ def test_edit_user_permissions_including_authentication_with_email_auth_service(
"send_messages",
"manage_templates",
"manage_service",
"manage_api_keys",
],
"login_authentication": "sms_auth",
},
Expand All @@ -728,7 +720,6 @@ def test_edit_user_permissions_including_authentication_with_email_auth_service(
"send_messages",
"manage_templates",
"manage_service",
"manage_api_keys",
},
folder_permissions=[],
)
Expand Down Expand Up @@ -1016,7 +1007,6 @@ def test_invite_user(
"send_messages",
"manage_templates",
"manage_service",
"manage_api_keys",
],
},
_follow_redirects=True,
Expand All @@ -1026,7 +1016,6 @@ def test_invite_user(
assert flash_banner == f"Invite sent to {email_address}"

expected_permissions = {
"manage_api_keys",
"manage_service",
"manage_templates",
"send_messages",
Expand Down Expand Up @@ -1127,7 +1116,6 @@ def test_invite_user_with_email_auth_service(
"send_messages",
"manage_templates",
"manage_service",
"manage_api_keys",
],
"login_authentication": auth_type,
},
Expand All @@ -1140,7 +1128,6 @@ def test_invite_user_with_email_auth_service(
assert flash_banner == "Invite sent to test@example.gsa.gov"

expected_permissions = {
"manage_api_keys",
"manage_service",
"manage_templates",
"send_messages",
Expand Down Expand Up @@ -1245,7 +1232,6 @@ def test_cancel_invited_user_doesnt_work_if_user_not_invited_to_this_service(
"Can See dashboard "
"Can Send messages "
"Can Manage settings, team and usage "
"Can Manage API integration "
"Cancel invitation for invited_user@test.gsa.gov"
),
),
Expand Down Expand Up @@ -1321,7 +1307,7 @@ def test_user_cant_invite_themselves(
service_id=SERVICE_ONE_ID,
_data={
"email_address": active_user_with_permissions["email_address"],
"permissions_field": ["send_messages", "manage_service", "manage_api_keys"],
"permissions_field": ["send_messages", "manage_service"],
},
_follow_redirects=True,
_expected_status=200,
Expand Down
2 changes: 0 additions & 2 deletions tests/end_to_end/test_invite_team_member_to_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ def test_invite_team_member_to_service(authenticated_page):
"Send messages",
"Add and edit templates",
"Manage settings, team and usage",
"Manage API integration",
]

# Check permission labels are on page
Expand All @@ -136,7 +135,6 @@ def test_invite_team_member_to_service(authenticated_page):
"See dashboard",
"Add and edit templates",
"Manage settings, team and usage",
"Manage API integration",
]

for checkbox in checkbox_list:
Expand Down
Loading