-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New guidance and subpages, and return to previous pages. #1949
Open
heyitsmebev
wants to merge
33
commits into
main
Choose a base branch
from
1928-develop-new-page-templates-in-code-to-sit-behind-the-log-in
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New guidance and subpages, and return to previous pages. #1949
heyitsmebev
wants to merge
33
commits into
main
from
1928-develop-new-page-templates-in-code-to-sit-behind-the-log-in
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
heyitsmebev
changed the title
Navigate easily to guidance and subpages, and return to previous pages.
New guidance and subpages, and return to previous pages.
Sep 19, 2024
…it-behind-the-log-in
alexjanousekGSA
force-pushed
the
1928-develop-new-page-templates-in-code-to-sit-behind-the-log-in
branch
from
October 9, 2024 16:20
061b26a
to
edca721
Compare
alexjanousekGSA
temporarily deployed
to
staging
October 9, 2024 16:20
— with
GitHub Actions
Inactive
…it-behind-the-log-in
…it-behind-the-log-in
alexjanousekGSA
temporarily deployed
to
staging
October 10, 2024 14:02
— with
GitHub Actions
Inactive
alexjanousekGSA
temporarily deployed
to
staging
October 10, 2024 15:29
— with
GitHub Actions
Inactive
alexjanousekGSA
temporarily deployed
to
staging
October 14, 2024 18:44
— with
GitHub Actions
Inactive
alexjanousekGSA
temporarily deployed
to
staging
October 15, 2024 16:54
— with
GitHub Actions
Inactive
…he-log-in' of https://github.com/GSA/notifications-admin into 1928-develop-new-page-templates-in-code-to-sit-behind-the-log-in
alexjanousekGSA
temporarily deployed
to
staging
October 17, 2024 17:10
— with
GitHub Actions
Inactive
alexjanousekGSA
temporarily deployed
to
staging
October 17, 2024 17:16
— with
GitHub Actions
Inactive
…it-behind-the-log-in
alexjanousekGSA
temporarily deployed
to
staging
October 17, 2024 17:17
— with
GitHub Actions
Inactive
alexjanousekGSA
temporarily deployed
to
staging
October 17, 2024 17:17
— with
GitHub Actions
Inactive
…he-log-in' of https://github.com/GSA/notifications-admin into 1928-develop-new-page-templates-in-code-to-sit-behind-the-log-in
alexjanousekGSA
temporarily deployed
to
staging
October 17, 2024 18:48
— with
GitHub Actions
Inactive
alexjanousekGSA
temporarily deployed
to
staging
October 17, 2024 18:48
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.
Description
In order to view the new content changes, navigate to
/guidance
This PR is intended to create a new guidance directory and to add in the side navigation along with breadcrumbs
Figma: https://www.figma.com/proto/aAWhlPzOP6kfVFnCCAfSZZ/notify.gov?page-id=2339%3A3817&node-id=4964-11162&viewport=2309%2C3419%2C0.25&t=JxwGA3dBSMSAqlqh-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=4854%3A212&show-proto-sidebar=1
Related issue: #1928
TODO (optional)
Should include a side navigation
Should include breadcrumbs
Implement guidance behind the log-in (permissions)
Should include approved content on each page
Should meet our accessibility standards
Should provide anchor links on sub pages
Layout should be flexible for both mobile and desktop views