Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New guidance and subpages, and return to previous pages. #1949

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

heyitsmebev
Copy link
Contributor

@heyitsmebev heyitsmebev commented Sep 19, 2024

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

In order to view the new content changes, navigate to /guidance

This PR is intended to create a new guidance directory and to add in the side navigation along with breadcrumbs

Figma: https://www.figma.com/proto/aAWhlPzOP6kfVFnCCAfSZZ/notify.gov?page-id=2339%3A3817&node-id=4964-11162&viewport=2309%2C3419%2C0.25&t=JxwGA3dBSMSAqlqh-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=4854%3A212&show-proto-sidebar=1

Related issue: #1928

TODO (optional)

  • Should include a side navigation

  • Should include breadcrumbs

  • Implement guidance behind the log-in (permissions)

  • Should include approved content on each page

  • Should meet our accessibility standards

  • Should provide anchor links on sub pages

  • Layout should be flexible for both mobile and desktop views

@heyitsmebev heyitsmebev linked an issue Sep 19, 2024 that may be closed by this pull request
4 tasks
@heyitsmebev heyitsmebev changed the title Navigate easily to guidance and subpages, and return to previous pages. New guidance and subpages, and return to previous pages. Sep 19, 2024
@heyitsmebev heyitsmebev self-assigned this Sep 19, 2024
@alexjanousekGSA alexjanousekGSA force-pushed the 1928-develop-new-page-templates-in-code-to-sit-behind-the-log-in branch from 061b26a to edca721 Compare October 9, 2024 16:20
@heyitsmebev heyitsmebev marked this pull request as ready for review October 15, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop new page templates in code to sit behind the log-in
3 participants