Second seminar 과제 제출 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyeoon00
requested review from
dev-Crayon,
sookyungg,
YuSuhwa-ve and
ddongseop
Open
4 tasks
ddongseop
reviewed
Apr 20, 2023
|
|
||
| @Getter | ||
| public class PriceUpdateDto { | ||
| @NotNull(message = "도서 고유번호는 필수입니다.") |
ddongseop
reviewed
Apr 20, 2023
|
|
||
| @Getter | ||
| public class RegisterRequestDto { | ||
| @NotBlank(message = "도서 제목은 필수입니다.") |
There was a problem hiding this comment.
[P5] 저는 NotNull밖에 사용해본적이 없어서, 이 코드를 보고 NotBlank와 NotEmpty까지 알아보는 시간을 가질 수 있었습니다!
- NotNull: Null만 허용하지 않음, 따라서 ""(초기화된 String)이나 " "(공백) 허용
- NotEmpty: Null과 ""(초기화된 String) 허용하지 않음, " "(공백)은 허용
- NotBlank: Null과 ""(초기화된 String), " "(공백) 모두 허용하지 않음
ddongseop
reviewed
Apr 20, 2023
| import java.util.List; | ||
|
|
||
| @Getter | ||
| public class BookListResponseDto { |
There was a problem hiding this comment.
[P5] Dto의 List를 담는 BookListResponseDto를 따로 정의하셨군요!
List에 있는 객체들을 Dto로 바꾸는 과정을 어디에서 처리해야할지 고민하다가 저는 그냥 Service 계층에서 처리했었는데, 뭔가 불만족스러웠거든요! 이렇게 처리하면 훨씬 깔끔한 것 같습니다!
ddongseop
reviewed
Apr 20, 2023
|
|
||
| @Builder.Default | ||
| private int view_count = 0; | ||
|
|
There was a problem hiding this comment.
[P5] 저는 이번에 생각 과제를 하면서 Builder 패턴에 대해 처음 알게되었는데, 이런 어노테이션도 존재하는군요!
빌더 패턴을 통해 인스턴스를 만들 때 특정 필드를 특정 값으로 초기화하고 싶다면 사용하는 Builder.Default,, 기억하겠습니다!
ddongseop
reviewed
Apr 20, 2023
YuSuhwa-ve
reviewed
Apr 20, 2023
| } | ||
|
|
||
| @PutMapping("/book") | ||
| public BookInfoResponseDto updatePrice(@RequestBody @Valid PriceUpdateDto priceUpdateDto) { |
There was a problem hiding this comment.
오 @Valid로 유효성 검증 좋아요. 나도 할걸.... 언니 코드 커비처럼 잡아먹어야지
| public class BookListResponseDto { | ||
| List<BookInfoResponseDto> bookInfoList; | ||
|
|
||
| public BookListResponseDto(List<Book> bookList) { |
There was a problem hiding this comment.
오 dto내부에서 로직을 넣어서 할수도 있구나! 난 지금까지 dto는 데이터 형식이라고만 생각했는데 이렇게 코드를 짜니 훨씬 깔끔하고 좋아요
|
|
||
| @Builder.Default | ||
| private int view_count = 0; | ||
|
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍟 기본과제
세미나에서 진행한 USER API & POST API 실습
🍕 심화과제
간단한 서점 프로그램을 만들어 아래 4개의 API를 구현하며 실습하였습니다.
[API 명세서] ➡️ https://lovely-watercress-8a3.notion.site/API-046fdf2ed510493da8b6f584f3962dd2
🍔 생각과제
2주차 생각과제는 아직 안 했는데 3주차 세미나 전까지 완료하겠습니다~!