[2주차] 기본과제 제출 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 프로젝트 명 javaPractice로 바꾸고 싶다,,
PgmJun
reviewed
Apr 21, 2023
There was a problem hiding this comment.
Animal을 동물의 종류인 Dog라는 이름의 클래스 등으로 상속해서 구현하는데,
그렇다면 종을 뜻하는 species 필드가 필요한 이유가 궁금합니다!
중복되는 내용이 아닌가 싶네요!
There was a problem hiding this comment.
null 사용보단 Optional을 이용해보는 것은 어떨까요!?
05AM
reviewed
Apr 28, 2023
| User user = userService.search(name); | ||
| // System.out.println("유저 이름 검색 인자: " + name); | ||
|
|
||
| return user != null ? user.toString() : "해당 이름을 가진 유저가 없습니다"; |
There was a problem hiding this comment.
return 값으로 optional을 준다면 좋을 것 같습니다!
Comment on lines
+31
to
+38
| public Post search(String title) { | ||
| for (Post post : postList) { | ||
| if (post.getTitle().equals(title)) { | ||
| return post; | ||
| } | ||
| } | ||
| return null; | ||
| } |
There was a problem hiding this comment.
title이 같은 게시물이 여러 개 있을 경우도 생각해본다면 좋을 것 같습니다.
KWY0218
approved these changes
Apr 28, 2023
Comment on lines
+16
to
+46
| @RestController | ||
| @RequiredArgsConstructor | ||
| public class PostController { | ||
| private final PostService postService; | ||
|
|
||
| @PostMapping("/post") | ||
| public String register(@RequestBody final RegisterRequestDto request) { | ||
| // 서비스 계층에 유저를 등록하는 메서드를 호출 | ||
| Long postId = postService.register(request); | ||
| // System.out.println(postList.get(postId.intValue() - 1).toString()); | ||
|
|
||
| return postId + "번 게시물이 등록되었습니다!"; | ||
| } | ||
|
|
||
| @GetMapping("/post/{postId}") | ||
| public String getOne(@PathVariable final Long postId) { | ||
| Post post = postService.getOne(postId); | ||
| // System.out.println("요청 유저 아이디: " + userId); | ||
|
|
||
| return post != null ? post.toString() : "해당 게시물이 존재하지 않습니다"; | ||
| } | ||
|
|
||
|
|
||
| @GetMapping("/post/search") | ||
| public String search(@RequestParam final String title) { | ||
| Post post = postService.search(title); | ||
| // System.out.println("유저 이름 검색 인자: " + name); | ||
|
|
||
| return post != null ? post.toString() : "해당 제목을 가진 게시물이 없습니다"; | ||
| } | ||
| } |
There was a problem hiding this comment.
@RequestMapping 을 사용해서 /post 중복을 없애보는 것이 어떨까요~?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기본 과제
심화 과제