add admin partition create API support (#379) #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [EnterpriseOnlyFact] | ||
| public async Task AdminPartition_CreateAdminPartition() | ||
| { | ||
| var cutOffVersion = SemanticVersion.Parse("1.11.0"); |
There was a problem hiding this comment.
Unfortunately, as for now we will not be able to run enterprise tests for versions 1.10+, so these test is going to be skipped, e.g.:
[xUnit.net 00:00:20.03] Consul.Test.AdminPartitionTest.AdminPartition_CreateAdminPartition [SKIP]
[xUnit.net 00:00:20.03] Skipped; this test requires a consul enterprise server to run.
We run enterprise tests only for versions before 1.10 -> https://github.com/G-Research/consuldotnet/blob/master/.github/workflows/ci.yml#L82-L88
I'm afraid we will not be able accept this PR because we are unable to test it at the moment.
There was a problem hiding this comment.
@marcin-krystianc makes sense, thanks. Please take a look at this other PR #382 when you have time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.