Add Choice teq #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuqq
previously approved these changes
May 30, 2024
ShapeSifter/TeqCrates.fsi
Outdated
| @@ -114,6 +114,32 @@ module OptionTeqCrate = | |||
| /// Otherwise, returns None. | |||
| val tryMake : unit -> 'a OptionTeqCrate option | |||
|
|
|||
| /// The type of values that act on a ChoiceTeqEvaluator. | |||
There was a problem hiding this comment.
Suggested change
| /// The type of values that act on a ChoiceTeqEvaluator. |
I appreciate that you're just following the existing comment structure here, but I don't think this sentence makes sense—if anything, it seems to me like values of this type act on the content of a Choice2TeqCrate.
There was a problem hiding this comment.
I was very unlucky in what I chose to copy-paste, it turns out! Most of the other cases of this are fine.
There was a problem hiding this comment.
Ah, I only actually scrolled up to OptionTeqEvaluator!
zuqq
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some reformatting of the TestPatterns file while I was at it. Probably view with ?w=1.