Release version 1.0 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
previously approved these changes
May 30, 2024
Smaug123
commented
May 30, 2024
| if [ $script_exit_code != 0 ] ; then | ||
| echo "Test failure: got exit code $script_exit_code when we expected 0" | ||
| exit $script_exit_code | ||
| fi |
There was a problem hiding this comment.
I haven't included a negative test here - I certainly could though. See https://github.com/Smaug123/WoofWare.Myriad/blob/6942ba42b977346bba8ddae44c879946b615c55f/.github/workflows/tag.sh for an example.
zuqq
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR releases to NuGet and bumps the version to 1.0 at the same time; if I or JonathanG have got something wrong, there's a chance we may need to make changes and re-release at a larger version number, which would be aesthetically displeasing. But I'm pretty confident; it worked for HeterogeneousCollections.
I've also added path filters, and adjusted the pipelines to cope with the duplicate releases that will result whenever path filters cause a release to be skipped. It took quite a lot of faff to detect the "conflicting release" error GitHub gives us and throw only if it's unrecognised; and I haven't even attempted to do that on the NuGet push stage. Nor have I worked out how to pass down into those steps some notion of "this release is expected to conflict".