Create "All required checks succeeded" check run when "All required checks done" CI job is actually successful #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "All required checks done" CI job has been designed to be a required check, but GitHub considers it successful when it's skipped, and it gets skipped when some of the jobs it depends on fail.
This PR fixes that by
always running the job and checking the results of all the jobs it depends onchecking in a separate workflow whether the job conclusion issuccess
and creates a new check run "All required checks succeeded" when it's the case. When it's not the case, the check run is not created and PRs will thus not be mergeable.Example runs:
I changed the workflow output slightly to show a ❌ when "All required checks done" is not successful, but this is not reflected in the above examples.