chore: optimize getTransactions query
#3336
Draft
+54
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torres-ssf
requested review from
digorithm,
arboleya,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #3336 will not alter performanceComparing Summary
|
|
Coverage Report:
Changed Files:
|
maschad
requested changes
Oct 15, 2024
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@fuel-ts/account": patch | |||
There was a problem hiding this comment.
"@fuel-ts/account": minor
Isn't this a breaking change given we changing the response of getTransactions to return two less fields? i.e. the id and transactionStatusFragment ?
There was a problem hiding this comment.
But @maschad The Provider.getTransactions has exactly the same response, no property was removed from it.
There was a problem hiding this comment.
I agree with you but if someone called provider.operations.getTransactions() the response would change and thus it's breaking.
danielbate
reviewed
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
Provider.getTransactionsSummary
This PR updates the getTransactions query to return only the
rawPayloadpropertyThe Provider.getTransactions method, which uses this query, only requires the
rawPayloadproperty. Therefore, the broadertransactionFragment, which includes unnecessary data, is no longer used.Since the
Provider.getTransactionsmethod did not use the additional fetched data included attransactionFragment, this change does not introduce any breaking changes.Checklist