Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For nested structures the function
make_structure_code
inasyncua.common.structures104.py
raised a RuntimeError exception.I now added for structure fields, which are structures again a further elif branch, which checks if the datatype is different and if it is a StrucutreField and then I assign the type
uaprotocol_auto.StructureField
.My first tests with nested structures look quite good:
And also structure with base types looks good:
If the pull request gets accepted I will remove the print statement before we/you merge it into master.