Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed function signature in Node #1690

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Fixed function signature in Node #1690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6e467e
Fix function signature
tanekere Jul 31, 2024
394eb86
change type hint to legacy style for 3.7
tanekere Jul 31, 2024
2c0bc23
same change is reflected in the sync wrapper
tanekere Jul 31, 2024
9fbb45c
updated CHANGELOG with fix info
tanekere Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Fix inconsistent type annotations as reported by mypy
[#1277](https://github.com/FreeOpcUa/opcua-asyncio/pull/1277)

- Fixed incorrect function signature in Node and it's Sync wrapper
[#1690](https://github.com/FreeOpcUa/opcua-asyncio/pull/1690)

## [1.0.2] - 2022-04-05

### Added
Expand Down
2 changes: 1 addition & 1 deletion asyncua/common/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ async def write_array_dimensions(self, value: int) -> None:
v = ua.Variant(value, ua.VariantType.UInt32)
await self.write_attribute(ua.AttributeIds.ArrayDimensions, ua.DataValue(v))

async def read_array_dimensions(self) -> int:
async def read_array_dimensions(self) -> List[int]:
"""
Read and return ArrayDimensions attribute of node
"""
Expand Down
2 changes: 1 addition & 1 deletion asyncua/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ def read_data_type(self) -> ua.NodeId: # type: ignore[empty-body]
pass

@syncmethod
def read_array_dimensions(self) -> int: # type: ignore[empty-body]
def read_array_dimensions(self) -> List[int]: # type: ignore[empty-body]
pass

@syncmethod
Expand Down