Ensure all internal links are relative #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #581 Relative paths _should_ always work, whether viewing docs as a file or via a web server, either locally or online
* master: Handle entities that might not have be correlated in resolving links
This seems to be a better and more consistent way than trying to filter each link individually
|
Thanks a lot! This seems to be working well, all the problems I had in #593 are now solved, and there is no significant impact on performance with this new strategy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #593 which ended up using a slow semi-brute force method. Instead, ensure
project_urlin templates is relative to current page when loading template, and pass every entity link through a relative-url filter.Fixes #581
@amorison hopefully this is better, fixing all the links without the massive slowdown