Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for running external executable on startup #2289

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mercury233
Copy link
Collaborator

It can be useful for something like update checker

@DailyShana
Copy link
Contributor

also useful for something like trojan?

@mercury233
Copy link
Collaborator Author

If the malware can modify system.conf, it can modify the main ygopro exe too, so this feature won't increase any risk.

@edo9300
Copy link
Contributor

edo9300 commented Apr 28, 2020

Rather than making the client spawn processes, the safer approach would be that the other process spawned the client.

@mercury233
Copy link
Collaborator Author

@edo9300 It won't be safer, and may require all old users to change the shortcut.

@salix5
Copy link
Collaborator

salix5 commented Dec 14, 2021

I think that there is a security concern too.
system.conf is a text file which can be modified easily, and some users might get the config file from some unknown sources.

Asking the users to run an update checker by themselves might be sort of awkward, but it is much safer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants