Add support for absolute transform #1409
Merged
+67
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derselbst
reviewed
Oct 20, 2024
There was a problem hiding this comment.
Looks good, thanks. A few comments below.
Also, a public interface for setting and getting the new transform field needs to be added as well. I.e.
fluid_mod_set_transform(fluid_mod_t *mod, int flags);
int fluid_mod_get_transform(const fluid_mod_t *mod);
Where flags is an enum representing the two possible values. And with API documentation.
|
I've added enums and the checks you wanted. The functions are added too (with the comments), but if there's a separate .md or .xml file with the docs, I didn't find it. And lastly, check my comment regarding new_fluid_mod in your review. |
|
derselbst
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1391
This PR adds support for absolute value modulator transform.
Also fixes duplicated "to ensure" in a comment.