Fix issue with CMake Xcode generator #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a known issue with CMake and its Xcode generator when the target has no sources of its own -- see https://gitlab.kitware.com/cmake/cmake/-/issues/23688 A workaround is to define an empty source file that can be used to trigger the build path for the framework. Without this hack, the framework is missing the shared library component. With this change, the following now runs successfully: `` % cmake -G Xcode -Denable-sdl2=NO -Denable-readline=NO -Denable-dbus=NO -DCMAKE_INSTALL_PREFIX=$PWD .. % xcodebuild ```
Merged
|
Kudos, SonarCloud Quality Gate passed!
|
derselbst
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Thanks Brad! I just added this to our MacCI and it works well.
Without your change:
https://dev.azure.com/tommbrt/tommbrt/_build/results?buildId=9499&view=logs&j=7055962f-51ce-5353-72ce-09bdafd645f3&t=d31a795d-4576-5a97-343e-1c458f9914b8
With your change:
https://dev.azure.com/tommbrt/tommbrt/_build/results?buildId=9510&view=logs&j=576a9cda-93b0-5727-f1c8-22833b424115&t=dff66e23-3473-587f-f9c1-9e625e695534
DominusExult
added a commit
to DominusExult/fluidsynth-sans-glib
that referenced
this pull request
Mar 6, 2024
* commit '683270db64302e59d26b9610514af1cfe0a80493': Bump to 2.3.5 Fix libinstpatch and sndfile not being discovered on Windows (FluidSynth#1299) Update FreeBSD CI: Drop 12.4 and add 14.0 Fix some rounding issues due to double promotion (FluidSynth#1286) Bump to 2.3.4 Fix player termination after stopping and restarting (FluidSynth#1273) fix for issue FluidSynth#1268: Pipewire's Jack implementation not found (FluidSynth#1269) Fix issue with CMake Xcode generator (FluidSynth#1266) Refurbish CI (FluidSynth#1267) Fallback to IPv4 when creating socket if IPv6 is not available (FluidSynth#1208) (FluidSynth#1265) Turn off pending notes and issue a warning (FluidSynth#1264) Fix incorrect way of turning CMAKE_INSTALL_LIBDIR absolute (FluidSynth#1261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known issue with CMake and its Xcode generator when the target has no sources of its own -- see
https://gitlab.kitware.com/cmake/cmake/-/issues/23688
A workaround is to define an empty source file that can be used to trigger the build path for the framework. Without this hack, the framework is missing the shared library component.
With this change, the following now runs successfully: