Update to Swift 4 & Xcode 9 + Update SwiftLint + Fix warnings

.swiftlint.yml

@@ -1,8 +1,29 @@
 opt_in_rules:
+- attributes
+- closure_end_indentation
+- closure_spacing
 - empty_count
+- explicit_init
+- file_header
+- first_where
+- let_var_whitespace
+- nimble_operator
+- no_extension_access_modifier
+- number_separator
+- object_literal
+- operator_usage_whitespace
+- overridden_super_call
+- private_outlet
+- prohibited_super_call
+- redundant_nil_coalescing
+- sorted_imports
+- switch_case_on_newline
+- trailing_closure
+- unneeded_parentheses_in_closure_argument
+- vertical_parameter_alignment_on_call
 
 disabled_rules:
-- vertical_whitespace # Turn off until configurable to 2 newlines
+- todo
 - cyclomatic_complexity
 
 included:
@@ -11,6 +32,108 @@ included:
 
 excluded:
 - Carthage
-- Sources/Constants
+- Package.swift
+- UsageExamples.playground
 
-line_length: 180
+line_length: 160
+
+file_header:
+  required_pattern: |
+                    \/\/
+                    \/\/  .*?\.swift
+                    \/\/  BartyCrouch
+                    \/\/
+                    \/\/  Created by [^\(\)\d\n]+ on \S{6,10}\.
+                    \/\/  Copyright © \d{4} Flinesoft\. All rights reserved\.
+                    \/\/
+custom_rules:
+  closing_brace_whitespace:
+    included: ".*.swift"
+    regex: '(?:\n| {2,})\}\)? *\n *[^ \n\})\]]'
+    name: "Closing Brace Whitespace"
+    message: "Empty line required after closing curly braces if code with same indentation follows."
+    severity: warning
+  closure_params_parantheses:
+    included: ".*.swift"
+    regex: '\{\s*\([^):]+\)\s*in'
+    name: "Unnecessary Closure Params Parantheses"
+    message: "Don't use parantheses around non-typed parameters in a closure."
+    severity: warning
+  if_as_guard:
+    included: ".*.swift"
+    regex: '\n *if [^\{]+\{\s*return[^\n]*\n *\}(?! *else)'
+    name: "If as Guard"
+    message: "Don't use an if statement to just return – use guard for such cases instead."
+    severity: warning
+  late_force_unwrapping:
+    included: ".*.swift"
+    regex: '\(\S+\?\.\S+\)!'
+    name: "Late Force Unwrapping"
+    message: "Don't use ? first to force unwrap later – directly unwrap within the parantheses."
+    severity: warning
+  multiple_closure_params:
+    included: ".*.swift"
+    regex: '\} *\) *\{'
+    name: "Multiple Closure Params"
+    message: "Don't use multiple in-line closures – save one or more of them to variables instead."
+    severity: warning
+  single_line_guard:
+    included: ".*.swift"
+    regex: 'guard[^\{]{2,80}else\s*\{\s*\n\s*return.{2,40}\}'
+    name: "Single Line Guard"
+    message: "Use a single line guard for simple checks."
+    severity: warning
+  too_much_indentation:
+    included: ".*.swift"
+    regex: '\n {0}[^\s\/][^\n]*[^,|&]\n+ {5,}\S|\n {4}[^\s\/][^\n]*[^,|&]\n+ {9,}\S|\n {8}[^\s\/][^\n]*[^,|&]\n+ {13,}\S|\n {12}[^\s\/][^\n]*[^,|&]\n+ {17,}\S|\n {16}[^\s\/][^\n]*[^,|&]\n+ {21,}\S|\n {20}[^\s\/][^\n]*[^,|&]\n+ {25,}\S'
+    name: "Too Much Indentation"
+    message: "Don't indent code by more than 4 whitespaces."
+    severity: warning
+  too_much_unindentation:
+    included: ".*.swift"
+    regex: ' {28}[^\s\.](.|[^\n]*[^\)][^\ ][^\}])\n+ {0,23}[^\s\/]| {24}[^\s\.](.|[^\n]*[^\)][^\ ][^\}])\n+ {0,19}[^\s\/]| {20}[^\s\.](.|[^\n]*[^\)][^\ ][^\}])\n+ {0,15}[^\s\/]| {16}[^\s\.](.|[^\n]*[^\)][^\ ][^\}])\n+ {0,11}[^\s\/]| {12}[^\s\.](.|[^\n]*[^\)][^\ ][^\}])\n+ {0,7}[^\s\/]| {8}[^\s\.](.|[^\n]*[^\)][^\ ][^\}])\n+ {0,3}[^\s\/]'
+    name: "Too Much Unindentation"
+    message: "Don't unindent code by more than 4 whitespaces."
+    severity: warning
+  unnecessary_case_break:
+    included: ".*.swift"
+    regex: '(case |default)(?:[^\n\}]+\n){2,}\s*break|\n *\n *break(?:\n *\n|\n *\})'
+    name: "Unnecessary Case Break"
+    message: "Don't use break in switch cases – Swift breaks by default."
+    severity: warning
+  unnecessary_nil_assignment:
+    included: ".*.swift"
+    regex: 'var \S+\s*:\s*[^\s]+\?\s*=\s*nil'
+    name: "Unnecessary Nil Assignment"
+    message: "Don't assign nil as a value when defining an optional type – it's nil by default."
+    severity: warning
+  vertical_whitespace_between_cases:
+    included: ".*.swift"
+    regex: '[^\n{][ \t]*\n[ \t]*(?:case[^\n]+|default):[ \t]*\n'
+    name: "Vertical Whitespace Between Cases"
+    message: "Include a vertical whitespace (empty line) between cases in switch statements."
+    severity: warning
+  vertical_whitespaces_around_mark:
+    included: ".*.swift"
+    regex: '\/\/\s*MARK:[^\n]*(\n\n)|(\n\n\n)[ \t]*\/\/\s*MARK:|[^\s{]\n[^\n\/]*\/\/\s*MARK:'
+    name: "Vertical Whitespaces Around MARK:"
+    message: "Include a single vertical whitespace (empty line) before and none after MARK: comments."
+    severity: warning
+  vertical_whitespace_opening_braces:
+    included: ".*.swift"
+    regex: '[{(\[][ \t]*\n[ \t]*\n'
+    name: "Vertical Whitespace after Opening Braces"
+    message: "Don't include vertical whitespace (empty line) after opening braces."
+    severity: warning
+  vertical_whitespace_closing_braces:
+    included: ".*.swift"
+    regex: '\n[ \t]*\n[ \t]*[)}\]]'
+    name: "Vertical Whitespace before Closing Braces"
+    message: "Don't include vertical whitespace (empty line) before closing braces."
+    severity: warning
+  whitespace_comment_start:
+    included: ".*.swift"
+    regex: '[^:]\/\/[^\s\/]'
+    name: "Whitespace Comment Start"
+    message: "A comment should always start with a whitespace."
+    severity: warning