Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove references to unversioned CDN links #4792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rolodato
Copy link
Member

@rolodato rolodato commented Nov 1, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This change removes unversioned CDN links as a suggested installation method to get started using the client-side JS SDK.

After #4767 was released, we now have proper versioned CDN links in our docs if customers really need it.

How did you test this code?

Running frontend locally:

image

@rolodato rolodato requested a review from a team as a code owner November 1, 2024 00:33
@rolodato rolodato requested review from kyle-ssg and removed request for a team November 1, 2024 00:33
Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 0:34am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 0:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 1, 2024 0:34am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4792 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4792 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4792 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4792 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4792 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4792 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Uffizzi Ephemeral Environment deployment-57838

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4792

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation updates front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant