Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add group admin to list groups #4779

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Adds the group_admin attribute to each user returned when listing groups for an organisation.

See here and here.

How did you test this code?

Added a new test.

@matthewelwell matthewelwell requested a review from a team as a code owner October 29, 2024 10:31
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team October 29, 2024 10:31
@github-actions github-actions bot added the api Issue related to the REST API label Oct 29, 2024
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 29, 2024 10:32am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Oct 29, 2024 10:32am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Oct 29, 2024 10:32am

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4779 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4779 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4779 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4779 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4779 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4779 Finished ✅ Results

@github-actions github-actions bot added the feature New feature or request label Oct 29, 2024
Copy link
Contributor

github-actions bot commented Oct 29, 2024

Uffizzi Preview deployment-57722 was deleted.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (56a266d) to head (55b9880).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4779   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files        1174     1174           
  Lines       40846    40878   +32     
=======================================
+ Hits        39744    39776   +32     
  Misses       1102     1102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 391b377 Oct 30, 2024
35 checks passed
@matthewelwell matthewelwell deleted the feat/add-group-admin-to-list-groups branch October 30, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants