Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid Segment base URLs #4727

Merged
merged 3 commits into from
Oct 15, 2024
Merged

fix: Invalid Segment base URLs #4727

merged 3 commits into from
Oct 15, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 15, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes

MissingSchema
Invalid URL 'api.segment.io/v1/batch': No scheme supplied. Perhaps you meant https://api.segment.io/v1/batch?

and adds a new migration to fix the invalid base URLs written by the previous migration.

How did you test this code?

We're going to test in staging, then in production.

@khvn26 khvn26 requested a review from a team as a code owner October 15, 2024 09:26
@khvn26 khvn26 requested review from zachaysan and removed request for a team October 15, 2024 09:26
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 15, 2024 9:42am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Oct 15, 2024 9:42am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Oct 15, 2024 9:42am

@github-actions github-actions bot added api Issue related to the REST API fix labels Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4727 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4727 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4727 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4727 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4727 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4727 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Uffizzi Preview deployment-57254 was deleted.

@github-actions github-actions bot added fix and removed fix labels Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (88acdfa) to head (e6f6c35).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4727   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files        1171     1172    +1     
  Lines       40497    40508   +11     
=======================================
+ Hits        39369    39380   +11     
  Misses       1128     1128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 8b823a7 Oct 15, 2024
35 checks passed
@khvn26 khvn26 deleted the fix/segment-base-urls branch October 15, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants