fix: Remove mailer lite #4705
Merged
fix: Remove mailer lite #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4705 +/- ##
========================================
Coverage 97.21% 97.21%
========================================
Files 1171 1169 -2
Lines 40651 40474 -177
========================================
- Hits 39517 39345 -172
+ Misses 1134 1129 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good, but I think there's an environment variable that we can still remove in the production task definition here.
Nice catch @matthewelwell I've removed the env var. |
matthewelwell
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removing mailer lite from the codebase since it has been deprecated.
How did you test this code?
Relying on existing test suite to handle failures.