Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GitHub integration tagging issues #4586

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Sep 4, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request
  • I have added information to docs/ if required so people know about the feature!

Changes

Solve #4585 and #4584

Unit tests updated

@novakzaballa novakzaballa requested a review from a team as a code owner September 4, 2024 14:50
@novakzaballa novakzaballa requested review from matthewelwell and removed request for a team September 4, 2024 14:50
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:19pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:19pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:19pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4586 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4586 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4586 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4586 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4586 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4586 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Uffizzi Preview deployment-55876 was deleted.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (d0a6caf) to head (f92e23e).
Report is 53 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4586   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files        1171     1172    +1     
  Lines       40651    40662   +11     
=======================================
+ Hits        39517    39528   +11     
  Misses       1134     1134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/integrations/github/github.py Outdated Show resolved Hide resolved
api/integrations/github/github.py Outdated Show resolved Hide resolved
api/integrations/github/github.py Outdated Show resolved Hide resolved
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be testing this on staging post merge.

api/integrations/github/github.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added fix and removed fix labels Oct 9, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 9, 2024
@matthewelwell matthewelwell self-requested a review October 24, 2024 10:17
@zachaysan zachaysan added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 56a266d Oct 28, 2024
35 checks passed
@zachaysan zachaysan deleted the fix/github-integration-tagging-issues branch October 28, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants