Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tests/private-packages): Add SAML, auth controller and workflow #4140

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jun 11, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add SAML, workflow and auth controller to private package test workflow

How did you test this code?

The workflow ran successfully here: https://github.com/Flagsmith/flagsmith/actions/runs/9533292963/job/26276374433?pr=4140

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 5:27am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 5:27am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 5:27am

@github-actions github-actions bot added the ci-cd Build, test and deployment related label Jun 11, 2024
@gagantrivedi gagantrivedi added the api Issue related to the REST API label Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

Uffizzi Preview deployment-52868 was deleted.

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jun 11, 2024
@gagantrivedi gagantrivedi added api Issue related to the REST API and removed api Issue related to the REST API labels Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (5c25c41) to head (847173d).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4140      +/-   ##
==========================================
+ Coverage   96.57%   96.60%   +0.03%     
==========================================
  Files        1190     1195       +5     
  Lines       38747    39099     +352     
==========================================
+ Hits        37419    37773     +354     
+ Misses       1328     1326       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi removed the api Issue related to the REST API label Jun 11, 2024
@gagantrivedi gagantrivedi force-pushed the tests/private-package/add-workflow branch from 1bd60eb to d9551ae Compare June 11, 2024 07:40
@github-actions github-actions bot removed the ci-cd Build, test and deployment related label Jun 11, 2024
@gagantrivedi gagantrivedi added api Issue related to the REST API ci-cd Build, test and deployment related and removed api Issue related to the REST API labels Jun 11, 2024
@gagantrivedi gagantrivedi force-pushed the tests/private-package/add-workflow branch from d9551ae to 95453ba Compare June 11, 2024 07:51
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jun 11, 2024
@gagantrivedi gagantrivedi added api Issue related to the REST API and removed api Issue related to the REST API labels Jun 11, 2024
@gagantrivedi gagantrivedi force-pushed the tests/private-package/add-workflow branch from 95453ba to aa0bb76 Compare June 11, 2024 08:08
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jun 11, 2024
@gagantrivedi gagantrivedi added the api Issue related to the REST API label Jun 11, 2024
@gagantrivedi gagantrivedi force-pushed the tests/private-package/add-workflow branch from aa0bb76 to b8c6595 Compare June 11, 2024 08:17
@gagantrivedi gagantrivedi removed the api Issue related to the REST API label Jun 11, 2024
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jun 11, 2024
@github-actions github-actions bot added the ci-cd Build, test and deployment related label Jul 1, 2024
@gagantrivedi gagantrivedi added api Issue related to the REST API and removed api Issue related to the REST API labels Jul 1, 2024
@gagantrivedi gagantrivedi force-pushed the tests/private-package/add-workflow branch from 6a7016e to 2aaec7e Compare July 1, 2024 03:54
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 1, 2024
@gagantrivedi gagantrivedi removed the api Issue related to the REST API label Jul 1, 2024
@gagantrivedi gagantrivedi added api Issue related to the REST API and removed api Issue related to the REST API labels Jul 1, 2024
@github-actions github-actions bot added api Issue related to the REST API ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 1, 2024
@gagantrivedi gagantrivedi added api Issue related to the REST API and removed api Issue related to the REST API labels Jul 1, 2024
@gagantrivedi gagantrivedi force-pushed the tests/private-package/add-workflow branch from bf44cbb to 8202119 Compare July 1, 2024 05:05
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 1, 2024
@gagantrivedi gagantrivedi added api Issue related to the REST API and removed api Issue related to the REST API labels Jul 1, 2024
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 1, 2024
@gagantrivedi gagantrivedi requested a review from khvn26 July 1, 2024 05:28
@gagantrivedi gagantrivedi added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit c2a33e6 Jul 1, 2024
29 checks passed
@gagantrivedi gagantrivedi deleted the tests/private-package/add-workflow branch July 1, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API ci-cd Build, test and deployment related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants